[QUALITY] Public fields should be [SerializeField] private for encapsulation #22

New issue

Open

opened 2026-03-12 00:03:38 +00:00 by lavarius · 0 comments

lavarius commented

2026-03-12 00:03:38 +00:00

Owner

🟡 Medium — Code Quality

Several classes expose fields as public when they should be [SerializeField] private to maintain encapsulation while keeping Unity Inspector visibility:

Interactable.cs: interactionIcon, fadeSpeed, targetAlpha, minAlpha
Radio.cs: audioSource, radioStations, localMP3Files
CameraManager.cs: CameraPrefab, MainCameraInstance
WorkIndicator.cs: All fields

Fix:

// Before:
public AudioSource audioSource;

// After:
[SerializeField] private AudioSource audioSource;

## 🟡 Medium — Code Quality Several classes expose fields as `public` when they should be `[SerializeField] private` to maintain encapsulation while keeping Unity Inspector visibility: - `Interactable.cs`: `interactionIcon`, `fadeSpeed`, `targetAlpha`, `minAlpha` - `Radio.cs`: `audioSource`, `radioStations`, `localMP3Files` - `CameraManager.cs`: `CameraPrefab`, `MainCameraInstance` - `WorkIndicator.cs`: All fields **Fix:** ```csharp // Before: public AudioSource audioSource; // After: [SerializeField] private AudioSource audioSource; ```