[ARCH] Zone behavior scattered across 3 classes — introduce ZoneManager with events #16

New issue

Closed

opened 2026-03-12 00:03:05 +00:00 by lavarius · 0 comments

lavarius commented

2026-03-12 00:03:05 +00:00

Owner

🟠 High — Architecture

Files: MovementManager.cs, AnimationController.cs, CharacterZoneChanger.cs

Zone change logic is scattered across three classes, each responding to zone changes independently via SendMessage. This creates duplicated state and tight implicit coupling.

Fix: Introduce a dedicated ZoneManager with a single C# event:

public static event Action<ZoneType> OnZoneChanged;

All interested classes subscribe/unsubscribe cleanly in OnEnable/OnDisable.

## 🟠 High — Architecture **Files:** `MovementManager.cs`, `AnimationController.cs`, `CharacterZoneChanger.cs` Zone change logic is scattered across three classes, each responding to zone changes independently via `SendMessage`. This creates duplicated state and tight implicit coupling. **Fix:** Introduce a dedicated `ZoneManager` with a single C# event: ```csharp public static event Action<ZoneType> OnZoneChanged; ``` All interested classes subscribe/unsubscribe cleanly in `OnEnable`/`OnDisable`.